Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50909][PYTHON][FOLLOWUP] Disable segfault tests in pypy #49720

Closed
wants to merge 1 commit into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jan 29, 2025

What changes were proposed in this pull request?

Disable segfault tests in pypy, same as in test_udf.

Why are the changes needed?

In pypy environment, segfault doesn't happen.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The existing tests should pass.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs). Thank you, @ueshin !

@dongjoon-hyun
Copy link
Member

I verified this manually with pypy.

$  python/run-tests --testnames pyspark.sql.tests.test_udtf
Running PySpark tests. Output is in /Users/dongjoon/APACHE/spark-merge/python/unit-tests.log
Will test against the following Python executables: ['python3.9', 'pypy3']
Will test the following Python tests: ['pyspark.sql.tests.test_udtf']
python3.9 python_implementation is CPython
python3.9 version is: Python 3.9.6
pypy3 python_implementation is PyPy
pypy3 version is: Python 3.10.14 (39dc8d3c85a7, Aug 27 2024, 20:40:24)
[PyPy 7.3.17 with GCC Apple LLVM 15.0.0 (clang-1500.3.9.4)]
Starting test(python3.9): pyspark.sql.tests.test_udtf (temp output: /Users/dongjoon/APACHE/spark-merge/python/target/28b3eb49-15a4-4601-8db0-218a23c31111/python3.9__pyspark.sql.tests.test_udtf__0rzn_8ml.log)
Starting test(pypy3): pyspark.sql.tests.test_udtf (temp output: /Users/dongjoon/APACHE/spark-merge/python/target/8fd56618-cdb0-4318-8f98-7b9ca4939f3d/pypy3__pyspark.sql.tests.test_udtf__zeg3y8jr.log)
Finished test(python3.9): pyspark.sql.tests.test_udtf (22s) ... 119 tests were skipped
Finished test(pypy3): pyspark.sql.tests.test_udtf (25s) ... 120 tests were skipped
Tests passed in 25 seconds

Skipped tests in pyspark.sql.tests.test_udtf with pypy3:
...
    test_udtf_segfault (pyspark.sql.tests.test_udtf.UDTFTests) ... skipped 'cannot run in environment pypy'
...

dongjoon-hyun pushed a commit that referenced this pull request Jan 29, 2025
### What changes were proposed in this pull request?

Disable segfault tests in `pypy`, same as in `test_udf`.

### Why are the changes needed?

In pypy environment, segfault doesn't happen.

- #49592 (review)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

The existing tests should pass.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49720 from ueshin/issues/SPARK-50909/pypy.

Authored-by: Takuya Ueshin <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 8dbf1dd)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

Merged to master/4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants