-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-51393][PYTHON] Fallback to regular Python UDF when Arrow is not found but Arrow-optimized Python UDFs enabled #50160
Closed
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
reviewed
Mar 5, 2025
ueshin
approved these changes
Mar 5, 2025
dongjoon-hyun
approved these changes
Mar 5, 2025
zhengruifeng
approved these changes
Mar 5, 2025
As mentioned in the PR description, this seems to have user-facing side-effect.
Just for the record, PyPy 3.10 CIs also have been broken in both I raised SPARK-51393's priority to cc @cloud-fan |
…mized Python UDFs enabled
This reverts commit 12f2967.
Merged to master and branch-4.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Mar 6, 2025
…t found but Arrow-optimized Python UDFs enabled ### What changes were proposed in this pull request? This PR extracts legitimate improvement in #49482. Falls back regular Python UDF when Arrow is not found but Arrow-optimized Python UDFs enabled. ### Why are the changes needed? To minimize end user impact. ### Does this PR introduce _any_ user-facing change? Yes, it falls back to regular Python UDF when Arrow is not found but Arrow-optimized Python UDFs enabled. ### How was this patch tested? Manually tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50160 from HyukjinKwon/SPARK-51393. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 74293cc) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR extracts legitimate improvement in #49482. Falls back regular Python UDF when Arrow is not found but Arrow-optimized Python UDFs enabled.
Why are the changes needed?
To minimize end user impact.
Does this PR introduce any user-facing change?
Yes, it falls back to regular Python UDF when Arrow is not found but Arrow-optimized Python UDFs enabled.
How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.