[SPARK-51097] [SS] Revert RocksDB instance metrics changes #50161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecookiez
changed the title
zecookiez
changed the title
zecookiez
changed the title
HeartSaVioR
approved these changes
Mar 6, 2025
|
Thanks! Merging to master. (For 4.0 I'll handle this in backport PR) |
HeartSaVioR
pushed a commit
that referenced
this pull request
Mar 6, 2025
### What changes were proposed in this pull request? SPARK-51097 Similar to #50161, this PR reverts the changes in branch-4.0 introduced from SPARK-51097. More specifically, this reverts the following commit: 55fc6f5 The context of this issue is that the newly introduced instance metrics have been unexpectedly showing up in Spark UI regardless of whether they are being used or not by the state stores. As a result, a query using 500 shuffle partitions would result in 500 instance metrics showing up in Spark UI (specifically, the SQL tab visualizing execution plan). The original PR from #49816 introduced a new type of SQL metrics denoting metrics for specific state store instances. This change only targeted RocksDB state stores. ### Why are the changes needed? This change is needed to revert an issue with the new instance metrics, where unused metrics would also show up on the Spark UI page. As a result, there would be hundreds of instance metrics showing up on the query visualizer. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Re-verified that RocksDBStateStoreIntegrationSuite is passing ### Was this patch authored or co-authored using generative AI tooling? No Closes #50165 from zecookiez/SPARK-51097-revert-4.0. Authored-by: Zeyu Chen <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-51097
This change reverts the changes in master introduced from SPARK-51097. More specifically, this reverts the following commit: da1854e
The context of this issue is that the newly introduced instance metrics have been unexpectedly showing up in Spark UI regardless of whether they are being used or not by the state stores. As a result, a query using 500 shuffle partitions would result in 500 instance metrics showing up in Spark UI (specifically, the SQL tab visualizing execution plan).
The original PR from #49816 introduced a new type of SQL metrics denoting metrics for specific state store instances. This change only targeted RocksDB state stores.
Why are the changes needed?
This change is needed to revert an issue with the new instance metrics, where unused metrics would also show up on the Spark UI page. As a result, there would be hundreds of instance metrics showing up on the query visualizer.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Re-verified that RocksDBStateStoreIntegrationSuite is passing
Was this patch authored or co-authored using generative AI tooling?
No