[SPARK-51722][SQL] Remove "stop" origin from ParseException#50518
Closed
gengliangwang wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-51722][SQL] Remove "stop" origin from ParseException#50518gengliangwang wants to merge 3 commits intoapache:masterfrom
gengliangwang wants to merge 3 commits intoapache:masterfrom
Conversation
viirya
reviewed
Apr 7, 2025
| throw new ParseException( | ||
| command = None, | ||
| start = start, | ||
| stop = stop, |
Member
There was a problem hiding this comment.
Oh, ParseException doesn't use stop actually.
Member
Author
There was a problem hiding this comment.
@viirya yes, for parser exception we just shall the start position with 3 ^s
viirya
reviewed
Apr 7, 2025
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Looks okay to me. One question, it is not used is because we simply don't need it or we miss using it, maybe we should consider to use it?
viirya
approved these changes
Apr 7, 2025
Member
Author
|
Thanks, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The "stop" origin from ParseException is not used. We should remove it to simplify code.
Why are the changes needed?
Code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT
Was this patch authored or co-authored using generative AI tooling?
No