Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL][MINOR] Fix warnings in DataSource/WriterV2Suites #50523

Closed
wants to merge 2 commits into from

Conversation

szehon-ho
Copy link
Contributor

@szehon-ho szehon-ho commented Apr 5, 2025

What changes were proposed in this pull request?

Fix compiler warnings in some DSV2 tests: method schema in trait Table is deprecated (since 3.4.0)
Also some simplification (use analysisException() method in cases where its possible)

Why are the changes needed?

Code hygiene to remove reference to deprecated method

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing unit test

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Apr 5, 2025
@szehon-ho
Copy link
Contributor Author

cc @cloud-fan @HyukjinKwon not urgent, thanks!

Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@szehon-ho
Copy link
Contributor Author

@cloud-fan thanks! reran the ci and now green

@HyukjinKwon
Copy link
Member

Merged to master.

@szehon-ho
Copy link
Contributor Author

Thanks @cloud-fan , @HyukjinKwon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants