Skip to content

[SPARK-38117][CORE] Expose stage level metrics in prometheus endpoint #52649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SPARK-38117][CORE] Expose stage level metrics in prometheus endpoint #52649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions core/src/main/scala/org/apache/spark/status/api/v1/PrometheusResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,41 @@ import org.apache.spark.ui.SparkUI
@Experimental
@Path("/executors")
private[v1] class PrometheusResource extends ApiRequestContext {

private case class ExecutorStageMetrics(
var memoryBytesSpilled: Long = 0L,
var diskBytesSpilled: Long = 0L,
var shuffleWriteRecords: Long = 0L,
var shuffleReadRecords: Long = 0L,
var inputRecords: Long = 0L,
var outputBytes: Long = 0L,
var outputRecords: Long = 0L
)
@GET
@Path("prometheus")
@Produces(Array(MediaType.TEXT_PLAIN))
def executors(): String = {
val sb = new StringBuilder
sb.append(s"""spark_info{version="$SPARK_VERSION_SHORT", revision="$SPARK_REVISION"} 1.0\n""")
val store = uiRoot.asInstanceOf[SparkUI].store

// Aggregate stage-level metrics for each executor
val executorStageMetrics =
scala.collection.mutable.Map[String, ExecutorStageMetrics]()
store.stageList(null).foreach { stage =>
val stageSummaries = store.executorSummary(stage.stageId, stage.attemptId)
stageSummaries.foreach { case (executorId, summary) =>
val current = executorStageMetrics.getOrElseUpdate(executorId, ExecutorStageMetrics())
current.memoryBytesSpilled += summary.memoryBytesSpilled
current.diskBytesSpilled += summary.diskBytesSpilled
current.shuffleWriteRecords += summary.shuffleWriteRecords
current.shuffleReadRecords += summary.shuffleReadRecords
current.inputRecords += summary.inputRecords
current.outputBytes += summary.outputBytes
current.outputRecords += summary.outputRecords
}
}

store.executorList(true).foreach { executor =>
val prefix = "metrics_executor_"
val labels = Seq(
Expand Down Expand Up @@ -103,6 +131,15 @@ private[v1] class PrometheusResource extends ApiRequestContext {
sb.append(s"$prefix${name}_seconds_total$labels ${m.getMetricValue(name) * 0.001}\n")
}
}
executorStageMetrics.get(executor.id).foreach { metrics =>
sb.append(s"${prefix}memoryBytesSpilled_bytes_total$labels ${metrics.memoryBytesSpilled}\n")
sb.append(s"${prefix}diskBytesSpilled_bytes_total$labels ${metrics.diskBytesSpilled}\n")
sb.append(s"${prefix}shuffleWriteRecords_total$labels ${metrics.shuffleWriteRecords}\n")
sb.append(s"${prefix}shuffleReadRecords_total$labels ${metrics.shuffleReadRecords}\n")
sb.append(s"${prefix}inputRecords_total$labels ${metrics.inputRecords}\n")
sb.append(s"${prefix}outputBytes_bytes_total$labels ${metrics.outputBytes}\n")
sb.append(s"${prefix}outputRecords_total$labels ${metrics.outputRecords}\n")
}
}
sb.toString
}
Expand Down