[SPARK-53934][CONNECT] Initial implement Connect JDBC driver #52705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Oct 23, 2025
Comment on lines
+89
to
+90
| case FloatType => 14 | ||
| case DoubleType => 24 |
There was a problem hiding this comment.
pan3793
commented
Oct 23, 2025
| test("get DatabaseMetaData from SparkConnectConnection") { | ||
| withConnection { conn => | ||
| val spark = conn.asInstanceOf[SparkConnectConnection].spark | ||
| val metadata = conn.getMetaData |
There was a problem hiding this comment.
Note: there are nearly 200 methods defined in DatabaseMetaData interface, in this Initial implementation, I only implemented some essential methods which is no ambiguity or required by BeeLine to work. The remaining methods will be implemented in subsequent PRs.
|
|
||
| package org.apache.spark.sql.connect.client.jdbc.util | ||
|
|
||
| import java.sql.{Array => _, _} |
There was a problem hiding this comment.
Shall we simply import Connection and ResultSet?
dongjoon-hyun
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
+1, LGTM. Thank you for making a progress on this, @pan3793 .
Merged to master to unblock the remaining dependent PRs. We can revise and polish more while developing this further.
|
@dongjoon-hyun thanks for quick review and merging, subsequent PRs will be submitted soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the initial implementation of the Connect JDBC driver. In detail, this PR implements the essential JDBC interfaces listed below.
java.sql.Driverjava.sql.Connectionjava.sql.Statementjava.sql.ResultSetjava.sql.ResultSetMetaDatajava.sql.DatabaseMetaDataAt the first step, this PR only supports
NullType,BooleanType,ByteType,ShortType,IntegerType,LongType,FloatType,DoubleType, andStringType.Why are the changes needed?
Basically implement the feature proposed in SPIP: JDBC Driver for Spark Connect
Does this PR introduce any user-facing change?
It's a new feature.
How was this patch tested?
New UTs are added.
And I have also cross-verified BeeLine cases with SPARK-54002 (#52706)
Was this patch authored or co-authored using generative AI tooling?
No.