[SPARK-54331][PYTHON][TESTS] Optimize pyspark.sql.tests.connect.test_connect_plan
#53032
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
pyspark.sql.tests.connect.test_connect_planpyspark.sql.tests.connect.test_connect_plan
HyukjinKwon
approved these changes
Nov 13, 2025
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 13, 2025
…_connect_plan` ### What changes were proposed in this pull request? Optimize `pyspark.sql.tests.connect.test_connect_plan`, by removing the remote session creation ### Why are the changes needed? Recently, I notice that this test become extremely slow, e.g. in https://github.com/apache/spark/actions/runs/19318125464/job/55253739424 before ``` Starting test(python3.11): pyspark.sql.tests.connect.test_connect_plan (temp output: /__w/spark/spark/python/target/763913e5-9ba0-46ed-a583-56bf5fa5f588/python3.11__pyspark.sql.tests.connect.test_connect_plan__nbrkokah.log) Finished test(python3.11): pyspark.sql.tests.connect.test_connect_plan (1222s) ``` after ``` Starting test(python3.11): pyspark.sql.tests.connect.test_connect_plan (temp output: /__w/spark/spark/python/target/45831997-66c0-4c44-89cf-1ce85dc89ee7/python3.11__pyspark.sql.tests.connect.test_connect_plan__tyaymd_b.log) Finished test(python3.11): pyspark.sql.tests.connect.test_connect_plan (1s) ``` The tests theirselves are pretty fast, so I think the root cause is the remote session creation which is not necessary in this test which is for validation of protobufs ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No Closes #53032 from zhengruifeng/opt_test_connect_plan. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 602a4bd) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Optimize
pyspark.sql.tests.connect.test_connect_plan, by removing the remote session creationWhy are the changes needed?
Recently, I notice that this test become extremely slow, e.g. in https://github.com/apache/spark/actions/runs/19318125464/job/55253739424
before
after
The tests theirselves are pretty fast, so I think the root cause is the remote session creation which is not necessary in this test which is for validation of protobufs
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No