[SPARK-54629][CONNECT][TEST] Supplement getString with BINARY type (UTF-8) test #53402
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to imports in SparkConnectJdbcDataTypeSuite
Contributor
Author
|
#53385 (comment) I create new pull request based on the new commits. |
LuciferYang
previously approved these changes
Dec 10, 2025
LuciferYang
dismissed
their stale review
This is not mandatory; there are numerous similar cases in the current codebase.
LuciferYang
reviewed
Dec 10, 2025
| assert(bytes.sameElements(testBytes2)) | ||
| assert(!rs.wasNull) | ||
|
|
||
| val stringValue = rs.getString("test_binary") |
Contributor
There was a problem hiding this comment.
I think these 3 lines would be fine.
Contributor
Author
There was a problem hiding this comment.
I restore to only leave these three lines.
Contributor
|
…s to imports in SparkConnectJdbcDataTypeSuite
xu20160924
changed the title
LuciferYang
approved these changes
Dec 11, 2025
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
+1, LGTM(pending tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add getString test coverage for BINARY type with UTF-8 encoding in "get binary type by column label" test
Why are the changes needed?
Test coverage
Does this PR introduce any user-facing change?
No
How was this patch tested?
./build/sbt -Phive "connect-client-jdbc/testOnly *SparkConnectJdbcDataTypeSuite"
[info] Run completed in 26 seconds, 574 milliseconds.
[info] Total number of tests run: 21
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 21, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
Was this patch authored or co-authored using generative AI tooling?
No