Skip to content

[SPARK-54651][CORE] Driver should delete temporary files when exiting during commit process #53406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AngersZhuuuu wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

[SPARK-54651][CORE] Driver should delete temporary files when exiting during commit process #53406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,13 @@ class HadoopMapReduceCommitProtocol(
val taskAttemptContext = new TaskAttemptContextImpl(jobContext.getConfiguration, taskAttemptId)
committer = setupCommitter(taskAttemptContext)
committer.setupJob(jobContext)
try {
val fs = stagingDir.getFileSystem(jobContext.getConfiguration)
fs.deleteOnExit(stagingDir)
Copy link
Member

@dongjoon-hyun dongjoon-hyun Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the streaming Spark jobs, this increases indefinitely, doesnt' it, @AngersZhuuuu ?

IMO, we had better consider this kind of behavior change as Improvement instead of Bug to avoid any side-effect. WDYT?

cc @mridulm

Copy link
Contributor

@cloud-fan cloud-fan Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think streaming job need to look at file source staging dir when restarting, this is not state store or checkpoint, cc @HeartSaVioR

Copy link
Contributor

@mridulm mridulm Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For streaming jobs, given their really long duration and large number of commits, we will keep accumulating the deleteOnExit metadata to be tracked - and eventually OOM.
I am assuming that is what @dongjoon-hyun is referring to - and I agree it is a risk.

At a minimum, we can derisk it by calling cancelDeleteOnExit for successful commits.

Btw, please do not catch Throwable

} catch {
case e: Throwable =>
logWarning(log"Exception while setting clean logic ${MDC(JOB_ID, jobContext.getJobID)}", e)
}
}

override def commitJob(jobContext: JobContext, taskCommits: Seq[TaskCommitMessage]): Unit = {
Expand Down