[WIP][SPARK-54652] Complete conversion of IDENTIFIER() #53407
+1,493
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2025 15:06
aleksandr-chernousov-db
changed the title
srielau
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
srielau
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
srielau
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
srielau
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
srielau
reviewed
Dec 9, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
Outdated
Show resolved
Hide resolved
srielau
reviewed
Dec 9, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
Outdated
Show resolved
Hide resolved
srielau
reviewed
Dec 9, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
Outdated
Show resolved
Hide resolved
| } | ||
| case (rfDelimited: RowFormatDelimitedContext, ffGeneric: GenericFileFormatContext) => | ||
| ffGeneric.identifier.getText.toLowerCase(Locale.ROOT) match { | ||
| getIdentifierText(ffGeneric.identifier).toLowerCase(Locale.ROOT) match { |
There was a problem hiding this comment.
I suppose here is also a keyword, not an identifier?
Contributor
There was a problem hiding this comment.
Correct the keyword appears to be TEXTFILE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I replace incorrect usages of "ctx.getText()" with "getIdentifierText(ctx)"
Why are the changes needed?
It blocks from using IDENTIFIER() in the remaining expected places
Does this PR introduce any user-facing change?
How was this patch tested?
Added new tests in identifier-clause.sql
Was this patch authored or co-authored using generative AI tooling?
Claude Sonnet 4.5