[SPARK-54670][CONNECT] Rework Connect Literal handling #53430
+1,029
−1,095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
commented
Dec 10, 2025
Contributor
Author
There was a problem hiding this comment.
Difference in Decimal handling:
[89.976200000000000000,89.976210000000000000] AS ARRAY(89.976200000000000000BD, 89.976210000000000000BD)#0, [89889.766723100000000000,89889.766723100000000000] AS ARRAY(89889.766723100000000000BD, 89889.766723100000000000BD)#0
[89.97620,89.97621] AS ARRAY(89.97620BD, 89.97621BD)#0, [89889.7667231,89889.7667231] AS ARRAY(89889.7667231BD, 89889.7667231BD)#0
hvanhovell
commented
Dec 10, 2025
Contributor
Author
There was a problem hiding this comment.
Difference in Binary handling:
0x0806 AS X'0806'#0,
[8,6] AS ARRAY(8Y, 6Y)#0
hvanhovell
commented
Dec 11, 2025
| expressions.Literal(value, dataType) | ||
| } | ||
|
|
||
| private object FromProtoToCatalystConverter extends FromProtoConvertor { |
Contributor
Author
There was a problem hiding this comment.
This directly converts the literal to its catalyst representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR fixes a number of problems with literal handling in Spark Connect:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Modified existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.