[SPARK-54673][SQL] Refactor SQL pipe syntax analysis code for sharing and reuse #53431
+35
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
approved these changes
Dec 10, 2025
peter-toth
approved these changes
Dec 11, 2025
| def validateAndStripPipeExpression( | ||
| pipeExpression: PipeExpression, | ||
| resolvedChild: Expression): Expression = { | ||
| val firstAggregateFunction: Option[AggregateFunction] = findFirstAggregate(resolvedChild) |
Contributor
There was a problem hiding this comment.
If possible, we should extract this outside this method and then pass it as an arg, because it is recursive.
Contributor
Author
There was a problem hiding this comment.
Thanks for review, I looked at this, it turns out we are always going to want to use the same expression-finding logic, so should be OK to leave this hard-coded in here.
Contributor
Author
|
I just looked at the test failure, it is unrelated. |
Contributor
Author
|
Thanks all for review, merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a small refactor of the SQL pipe syntax analysis code for sharing and reuse.
Why are the changes needed?
The new analyzer can refer to the refactored code without duplicating it.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A, this is a small refactoring only.
Was this patch authored or co-authored using generative AI tooling?
No