-
Notifications
You must be signed in to change notification settings - Fork 268
#1662 - Migrate to Maven 4 #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…t inference and subprojects discovery
|
In some POMs we're using tabs for indentation, while in others we have double spaces. Should we agree on a common style and update them? |
|
Thx. Can we update the action to run with an actual Maven 4 binary? Most likely other ASF projects are doing it similar or https://github.com/s4u/setup-maven-action?tab=readme-ov-file or alike are already Maven 4 ready? I have no preference regarding formatting. |
| <packaging>pom</packaging> | ||
|
|
||
| <dependencies> | ||
| <subprojects> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In RC 5, you can no longer have submodules together with jar packaging, so I updated accordingly.
| with: | ||
| distribution: adopt | ||
| java-version: 17 | ||
| - name: Install Maven 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the easiest way I found to build with specific maven 4 versions. @rzo1 I think that the GitHub action you shared didn't work due to ASF restrictions on action repositories.
#1662 Changes for Maven 4 compatibility following the official migration guidelines 1|2.
Steps followed:
mvnup apply --model-version 4.1.0 --all