feat: Add Ant Design 5 Theme #29328
feat: Add Ant Design 5 Theme #29328
Conversation
dosubot
bot
added
change:frontend
|
Can you convert this to a draft given that the SIP was not approved yet? |
michael-s-molina
added
the
review:checkpoint
geido
force-pushed
the
geido/feat/ant-design-5-theme
branch
from
46348ec
to
219f856
Compare
john-bodley
removed
the
review:checkpoint
geido
requested review from
rusackas,
justinpark,
eschutho,
Antonio-RiveroMartnez and
kgabryje
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://52.35.19.68:8080. Credentials are |
| fontSizeSM: supersetTheme.typography.sizes.s, | ||
| fontSizeXL: supersetTheme.typography.sizes.xl, | ||
|
|
||
| lineWidthBold: supersetTheme.gridUnit / 2, |
There was a problem hiding this comment.
Nit: do we want to tie this to the grid unit?
There was a problem hiding this comment.
We can revisit this as we continue the upgrade. The general theme is the result of the usage of the individual components, so this needs to be thought of as a draft for now.
There was a problem hiding this comment.
Looks good to me! Suggestion for future iterations - since antd5's theming is a new concept in Superset, could we have some descriptive comments or references to docs where they're relevant (such as what is a theme algorithm, what tokens are available etc)? I think it will make the transition easier for us
|
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This work is part of SIP 139 #29268.
This PR introduces Ant Design 5 in the repo and adds the initial Ant Design mapping with the original Superset theme to allow overrides through preamble. This should serve as the base for the Ant Design upgrade. As new components are upgraded, this initial mapping will be adjusted accordingly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION