-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to NOT LIKE operator #29384
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and col not in self.column_names | ||
and col not in applied_template_filters | ||
] + rejected_adhoc_filters_columns | ||
col |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like our linters are behaving different, follow the steps here and you should get our standard dev tools like ruff and pylint through the pip install, and pre-commit hooks setup
https://superset.apache.org/docs/contributing/development/#installing-development-tools
@@ -1873,9 +1874,9 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma | |||
if ( | |||
op | |||
not in { | |||
utils.FilterOperator.EQUALS.value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as this looks properly indented in master
RN...
https://github.com/apache/superset/blob/master/superset/models/helpers.py#L1875-L1878 (?)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29384 +/- ##
==========================================
+ Coverage 60.48% 70.34% +9.85%
==========================================
Files 1931 1961 +30
Lines 76236 78481 +2245
Branches 8568 8961 +393
==========================================
+ Hits 46114 55205 +9091
+ Misses 28017 21079 -6938
- Partials 2105 2197 +92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
Change
get_sqla_query
method ofhelpers.py
to supportNOT_LIKE
operatorTESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION