Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to NOT LIKE operator #29384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dacopan
Copy link

@dacopan dacopan commented Jun 26, 2024

SUMMARY

Change get_sqla_query method of helpers.py to support NOT_LIKE operator

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

and col not in self.column_names
and col not in applied_template_filters
] + rejected_adhoc_filters_columns
col
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like our linters are behaving different, follow the steps here and you should get our standard dev tools like ruff and pylint through the pip install, and pre-commit hooks setup

https://superset.apache.org/docs/contributing/development/#installing-development-tools

@@ -1873,9 +1874,9 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
if (
op
not in {
utils.FilterOperator.EQUALS.value,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as this looks properly indented in master RN...
https://github.com/apache/superset/blob/master/superset/models/helpers.py#L1875-L1878 (?)

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (76d897e) to head (56b6b02).
Report is 375 commits behind head on master.

Files Patch % Lines
superset/models/helpers.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29384      +/-   ##
==========================================
+ Coverage   60.48%   70.34%   +9.85%     
==========================================
  Files        1931     1961      +30     
  Lines       76236    78481    +2245     
  Branches     8568     8961     +393     
==========================================
+ Hits        46114    55205    +9091     
+ Misses      28017    21079    -6938     
- Partials     2105     2197      +92     
Flag Coverage Δ
hive 48.87% <25.00%> (-0.30%) ⬇️
javascript 58.02% <ø> (+0.31%) ⬆️
mysql 77.24% <50.00%> (?)
postgres 77.34% <50.00%> (?)
presto 53.47% <25.00%> (-0.34%) ⬇️
python 83.69% <50.00%> (+20.20%) ⬆️
sqlite 76.80% <50.00%> (?)
unit 59.16% <37.50%> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants