Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Table): Add aria-label to Table page size selector #29391

Merged
merged 3 commits into from
Jun 28, 2024
Merged

chore(Table): Add aria-label to Table page size selector #29391

merged 3 commits into from
Jun 28, 2024

Conversation

geido
Copy link
Member

@geido geido commented Jun 27, 2024 •
edited
Loading

SUMMARY

Makes the page size selector for the table accessible to screen readers

BEFORE/AFTER

image

TESTING INSTRUCTIONS

  1. Interact with a page size selector of a table via screen reader
  2. The screen reader should be able to read the size selector

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the design:accessibility Related to accessibility standards label Jun 27, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Jun 28, 2024
@geido
Copy link
Member Author

geido commented Jun 28, 2024

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://35.91.167.215:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido requested a review from kgabryje June 28, 2024 13:47
kgabryje
kgabryje approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geido geido merged commit 66bc8ce into master Jun 28, 2024
33 of 34 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas deleted the geido/chore/accessiblity-table-entries branch June 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley left review comments

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
design:accessibility Related to accessibility standards plugins review:checkpoint Last PR reviewed during the daily review standup size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geido @john-bodley @kgabryje