Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable injecting custom html into head #29917

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Aug 12, 2024

SUMMARY

Enable injecting custom <link>, <meta>, <style> etc. elements into .

Similarly to how tail_js_custom_extra.html works, this PR adds head_custom_extra.html file where users can define elements that will be injected into head.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Add some html code to head_custom_extra.html file, verify that it appears in <head>

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend global:theming Related to theming Superset labels Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (76d897e) to head (b2136de).
Report is 579 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29917       +/-   ##
===========================================
+ Coverage   60.48%   83.70%   +23.21%     
===========================================
  Files        1931      527     -1404     
  Lines       76236    38052    -38184     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31851    -14263     
+ Misses      28017     6201    -21816     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.02% <ø> (-0.15%) ⬇️
javascript ?
mysql 76.76% <ø> (?)
postgres 76.86% <ø> (?)
presto 53.56% <ø> (-0.24%) ⬇️
python 83.70% <ø> (+20.21%) ⬆️
sqlite 76.34% <ø> (?)
unit 60.36% <ø> (+2.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgabryje kgabryje merged commit c016ca5 into apache:master Aug 12, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend global:theming Related to theming Superset size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants