Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log warnings for database tables api #30410

Merged
merged 2 commits into from
Sep 30, 2024
Merged

chore: log warnings for database tables api #30410

merged 2 commits into from
Sep 30, 2024

Conversation

eschutho
Copy link
Member

SUMMARY

Adding more logs for warnings for the databases/tables api

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Sep 26, 2024
eschutho
eschutho commented Sep 26, 2024
View reviewed changes
superset/views/error_handling.py
if ex.status >= 500:
logger.exception(ex)
logger_func, _ = get_logger_from_status(ex.status)
logger_func(ex.message, exc_info=True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also in #30365

@eschutho eschutho marked this pull request as ready for review September 26, 2024 23:44
@dosubot dosubot bot added the logging Creates a UI or API endpoint that could benefit from logging. label Sep 26, 2024
mistercrunch
mistercrunch approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

betodealmeida
betodealmeida approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log all the warnings! :)

@eschutho eschutho merged commit 2e50167 into master Sep 30, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
api Related to the REST API logging Creates a UI or API endpoint that could benefit from logging. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eschutho @mistercrunch @betodealmeida