feat: reduce some filter width in list views #31596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in our CRUD list views (dashboards, charts, datasets) we use a fixed width of 200px for all filters, regardless of their content. This leads to some filter rows overflowing depending on use screen width. Here I'm setting some of the filters to be thinner, preventing filters from wrapping into 2 rows.
In the future version of antd, we'll be able to shrink all filters to thinner width with `popupMatchSelectWidth={false}`, allowing for the dropdown width to be wider than the input box.
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
mistercrunch
requested review from
michael-s-molina,
geido and
kgabryje
as code owners
dosubot
bot
added
the
listview
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this frog.
.--._.--.
( O O )
/ . . \
.`._______.'.
/( )\
_/ \ \ / / \_
.~ ` \ \ / / ' ~.
{ -. \ V / .- }
_ _`. \ | | | / .'_ _
>_ _} | | | {_ _<
/. - ~ ,_-' .^. `-_, ~ - .\
'-'|/ \|`-`Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/components/ListView/Filters/Base.ts | ✅ |
| superset-frontend/src/components/ListView/types.ts | ✅ |
| superset-frontend/src/components/ListView/Filters/index.tsx | ✅ |
| superset-frontend/src/components/ListView/Filters/Select.tsx | ✅ |
| superset-frontend/src/components/Select/Select.tsx | ✅ |
| superset-frontend/src/pages/DashboardList/index.tsx | ✅ |
| superset-frontend/src/pages/ChartList/index.tsx | ✅ |
| superset-frontend/src/pages/DatasetList/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
|
@kasiazjc take a look and see if there are any other changes you would want to be made here. |
|
/testenv up |
|
@sadpandajoe Processing your ephemeral environment request here. |
|
@sadpandajoe Ephemeral environment spinning up at http://35.89.6.135:8080. Credentials are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in our CRUD list views (dashboards, charts, datasets) we use a fixed width of 200px for all filters, regardless of their content. This leads to some filter rows overflowing depending on use screen width. Here I'm setting some of the filters to be thinner, preventing filters from wrapping into 2 rows.
In the future version of antd, we'll be able to shrink all filters to thinner width with
popupMatchSelectWidth={false}, allowing for the dropdown width to be wider than the input box.before
after