fix: update the data-table tooltip to show proper "All", which means … #32268
Conversation
…no pagination (used to be 0)
github-actions
bot
added
i18n
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/pagination.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
|
I'm not sure how translations are updated/sourced - is it expected that they would be updated in this PR here too? Or...some clever LLM-translation automation? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32268 +/- ##
===========================================
+ Coverage 60.48% 83.45% +22.96%
===========================================
Files 1931 546 -1385
Lines 76236 39097 -37139
Branches 8568 0 -8568
===========================================
- Hits 46114 32629 -13485
+ Misses 28017 6468 -21549
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -8814,7 +8814,7 @@ msgstr "Omejitev števila vrstic" | |||
| msgid "Rows" | |||
| msgstr "Vrstice" | |||
|
|
|||
| msgid "Rows per page, 0 means no pagination" | |||
| msgid "Rows per page, All means no pagination" | |||
| msgstr "Vrstic na stran (0 pomeni brez številčenja strani)" | |||
There was a problem hiding this comment.
Maybe GPT or Google Translate can help adjust these translated strings as well, while we're at it?
There was a problem hiding this comment.
Yeah I can sort it.
We're looking at some AI solutions to flesh out the translations and help keep them up to date... meanwhile it's a manual process. If you have the wherewithal to use GPT or whatever to update them, that'd be nice. Otherwise, I can take a crack at it when time allows... but it would be nice not to have to leave it to others to make the touch-ups, I reckon. |
…no pagination (used to be 0)
SUMMARY
Tooltip info update - the now "All" means no pagination (it used to be 0)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Verify tooltip & translations of same.
ADDITIONAL INFORMATION