fix: SUPERSET_LOAD_EXAMPLES=no are not respect when using environment variables

[thiagodamas]

SUMMARY

SUPERSET_LOAD_EXAMPLES=no are not respect when using environment variables

You can check by using "docker compose config"

It maybe related to docker/compose#12449

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[mistercrunch]

Wait, it works for me, and would work after this change...

Trace:
how I ran it:

shows only 3 steps in init instead of 4 (excludes loading the examples)

My env:

[mistercrunch]

if it's a docker compose bug, maybe you can force install the same version as the one I use (?)

[mistercrunch]

If there's a known issue on some docker-compose versions, we could alter the check-env.py script to disallow certain docker-compose versions.

[thiagodamas]

Wait, it works for me, and would work after this change...

Trace: how I ran it: shows only 3 steps in init instead of 4 (excludes loading the examples)

My env:

Its works this way, but it doesn't work when SUPERSET_LOAD_EXAMPLES=no is inside docker/.env or docker/.env-local, I already tried both ways.

[mistercrunch]

Oh interesting. I'm not sure what that informs though.

So then the issue is that env_file: directives don't play nice with envrionment: directives? Is this a bug or a misunderstanding?

Should we move away from environment and set all defaults in .env, tell people to use .env-local? Gets a little messy as these .env files are used across services and things, and have a mix of things people should and shouldn't mess with...

[thiagodamas]

Oh interesting. I'm not sure what that informs though.

So then the issue is that env_file: directives don't play nice with envrionment: directives? Is this a bug or a misunderstanding?

Should we move away from environment and set all defaults in .env, tell people to use .env-local? Gets a little messy as these .env files are used across services and things, and have a mix of things people should and shouldn't mess with...

For me it appears to be a bug, conflict order when using, inside docker compose, environment and env_file directives; when using like above (using with export or prefixed the docker command) (#32269 (comment)) it works

[mistercrunch]

While the .env/.env-local are used globally across services, it feels the envrionment directive would be great as per-service overrides. Now i don't think we ever need to diverge env vars from a service to another (?) Maybe that informs we could nuke all envrionment directives and instruct people to either use .env-local or run their own export K=V, assuming this all works as expected (?)