Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viz): update nesting logic to handle multiple dimensions in PartitionViz #32290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DamianPendrak
Copy link
Contributor

Fixes #32042

SUMMARY

Updated nest_values to support multiple dimensions, enabling correct filtering of nested properties.

ADDITIONAL INFORMATION

@dosubot dosubot bot added the viz:charts:partition Related to the Partition chart label Feb 17, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Fix Detected
Functionality Invalid list concatenation ▹ view
Functionality Missing dimension validation in nested structure ▹ view
Files scanned
File Path Reviewed
superset/viz.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Feedback and Support

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (76d897e) to head (df5a139).
Report is 1453 commits behind head on master.

Files with missing lines Patch % Lines
superset/viz.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32290       +/-   ##
===========================================
+ Coverage   60.48%   83.45%   +22.96%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39101    -37135     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32632    -13482     
+ Misses      28017     6469    -21548     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.49% <0.00%> (-0.67%) ⬇️
javascript ?
mysql 75.85% <80.00%> (?)
postgres 75.92% <80.00%> (?)
presto 53.02% <0.00%> (-0.79%) ⬇️
python 83.45% <80.00%> (+19.96%) ⬆️
sqlite 75.43% <80.00%> (?)
unit 61.06% <0.00%> (+3.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 17, 2025
@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. hold! On hold labels Feb 18, 2025
@sadpandajoe sadpandajoe requested a review from geido February 19, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold! On hold preset:bounty Issues that have been selected by Preset and have a bounty attached. size/M viz:charts:partition Related to the Partition chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition Chart renders subcategories incorrectly when using more than two dimensions
2 participants