-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump major versions for math-expression-evaluator
and fetch-mock
+ clean up obsolete dev/override packages
#32322
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: hainenber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
File Path | Reviewed |
---|---|
superset-frontend/packages/superset-ui-core/src/math-expression/index.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Signed-off-by: hainenber <[email protected]>
… overrides Signed-off-by: hainenber <[email protected]>
math-expression-evaluator
to major v2math-expression-evaluator
to major v2 + clean up obsolete package overrides + clean up obsolete dev deps
Signed-off-by: hainenber <[email protected]>
322fbb2
to
09c28ed
Compare
math-expression-evaluator
to major v2 + clean up obsolete package overrides + clean up obsolete dev depsmath-expression-evaluator
and sinon
+ clean up obsolete dev/override packages
…ancements Signed-off-by: hainenber <[email protected]>
09c28ed
to
e76c10b
Compare
…loader` Signed-off-by: hainenber <[email protected]>
…age format Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…cal vuln Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…-specific timeouts Signed-off-by: hainenber <[email protected]>
This reverts commit beea934.
Signed-off-by: hainenber <[email protected]>
math-expression-evaluator
and sinon
+ clean up obsolete dev/override packagesmath-expression-evaluator
and fetch-mock
+ clean up obsolete dev/override packages
@hainenber Did you verify that the major bumps won't have breaking changes that will affect superset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending an answer to @sadpandajoe 's question. Also, I'm happy to see all the timeouts go away... as long as that's stable. We can increase the global timeout for all tests if it makes things more stable, I suppose.
@sadpandajoe there's a unit test for the function that utilizes I also checked the release note for v2. The described breaking change doesn't apply as we don't use the functions that received breaking changes. |
SUMMARY
build(deps): bump major versions for
math-expression-evaluator
andfetch-mock
+ clean up obsolete dev/override packagesmath-expression-evaluator
(v1 -> 2) andfetch-mock
(v7 -> v9).react-test-renderer
mock-socket
exports-loader
ignore-styles
webpack
for that sweet performance enhancements.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION