Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump major versions for math-expression-evaluator and fetch-mock + clean up obsolete dev/override packages #32322

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Feb 20, 2025

SUMMARY

build(deps): bump major versions for math-expression-evaluator and fetch-mock + clean up obsolete dev/override packages

  • Bump major versions for math-expression-evaluator (v1 -> 2) and fetch-mock (v7 -> v9).
  • Clean up obsolete package overrides.
  • Remove extraneous dev deps
    • react-test-renderer
    • mock-socket
  • Remove unused dev deps:
    • exports-loader
    • ignore-styles
  • Bump minor version for webpack for that sweet performance enhancements.
  • Increase the global timeout for Jest tests to 20 seconds to (partially) fix the flakiness nuisance.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/packages/superset-ui-core/src/math-expression/index.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@hainenber hainenber changed the title build(deps): bump math-expression-evaluator to major v2 build(deps): bump math-expression-evaluator to major v2 + clean up obsolete package overrides + clean up obsolete dev deps Feb 20, 2025
@hainenber hainenber force-pushed the chore/bump-mexp-major-ver branch from 322fbb2 to 09c28ed Compare February 20, 2025 08:41
@hainenber hainenber changed the title build(deps): bump math-expression-evaluator to major v2 + clean up obsolete package overrides + clean up obsolete dev deps build(deps): bump major versions for math-expression-evaluator and sinon + clean up obsolete dev/override packages Feb 20, 2025
@hainenber hainenber force-pushed the chore/bump-mexp-major-ver branch from 09c28ed to e76c10b Compare February 20, 2025 08:45
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 20, 2025
@hainenber hainenber changed the title build(deps): bump major versions for math-expression-evaluator and sinon + clean up obsolete dev/override packages build(deps): bump major versions for math-expression-evaluator and fetch-mock + clean up obsolete dev/override packages Feb 20, 2025
@sadpandajoe
Copy link
Member

@hainenber Did you verify that the major bumps won't have breaking changes that will affect superset

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending an answer to @sadpandajoe 's question. Also, I'm happy to see all the timeouts go away... as long as that's stable. We can increase the global timeout for all tests if it makes things more stable, I suppose.

@hainenber
Copy link
Contributor Author

Did you verify that the major bumps won't have breaking changes that will affect superset

@sadpandajoe there's a unit test for the function that utilizes math-to-expression-evaluator library and it passed.

I also checked the release note for v2. The described breaking change doesn't apply as we don't use the functions that received breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants