fix: Clicking in the body of a Markdown component does not put it into edit mode #32335
Conversation
…it mode on click
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Redundant Edit Mode State Logic ▹ view | ✅ |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx | ✅ |
| superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx | ✅ |
| superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
| let nextState = { | ||
| ...this.state, | ||
| editorMode: mode, | ||
| isEditing: mode === 'edit', | ||
| }; | ||
|
|
||
| if(mode == 'edit') { | ||
| nextState = { | ||
| ...this.state, | ||
| editorMode: 'edit', | ||
| isEditing: true, | ||
| }; | ||
| console.log('here'); | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sadpandajoe
changed the title
sadpandajoe
changed the title
|
Thanks for the PR! Looks like there's linting failures, please see the logs of the failed tests and work to get prettier etc. pre-commit checks passing locally. |
…does not put it into edit mode
|
|
|
@rusackas Ephemeral environment spinning up at http://34.209.3.204:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
|
Oh, actually, the test failures seem relevant. Would you be willing to take a look at the event triggers there and see if you can get things to pass? You can run the single test from the |
|
Sure I am looking into it. |
…does not put it into edit mode
…does not put it into edit mode
…does not put it into edit mode
…does not put it into edit mode
|
For some reason i am not able to run test locally, can you check this request, otherwise I will find solution for running test locally. |
|
Yep I just approved test runs. I have had trouble getting my local environment set up too so I get it! |
|
@sfirke why this one test is failing i do not understand, or is there any docs for running test locally? |
…does not put it into edit mode
|
@rusackas this is now passing CI, could you take a look when you get a chance? |
|
Oh maybe I spoke too soon, it looks like the last commit removed the failing test. @notHuman9504 I'm reluctant to have this pass CI by removing the test unless we understand why the test failed and feel that it was invalid. It would be better to fix the test if needed. |
…does not put it into edit mode
|
hey @sfirke now you can check I have done a all nighter to fix it. |
|
@sfirke hey some test in data models is failing, i didn't do any changes in database can you re run test or tell me what's wrong? |
|
@rusackas can you re run the test? |
I have created a on click event on div which is helping to fix issue.
fixes: #32252