fix(firebolt): allow backslach escape for single quotes

[betodealmeida]

SUMMARY

Fix for the Firebolt dialect (old), which accepts \' for escaping single quotes, meaning both are valid:

SELECT 'She''s my inspiration';
SELECT 'She\'s my inspiration';

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added a test.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

[rusackas]

/korbit-review

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Fix Detected
	Tokenizer Added to Wrong Dialect Class ▹ view

Files scanned

​

File Path	Reviewed
superset/sql/dialects/firebolt.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[korbit-ai]

Tokenizer Added to Wrong Dialect Class

Tell me more

What is the issue?

The STRING_ESCAPES list is defined but the Tokenizer class is added to FireboltOld instead of the main Firebolt dialect class, which doesn't align with the developer's intent to add escaping support for the Firebolt dialect.

Why this matters

Users of the main Firebolt dialect won't have access to the backslash escaping functionality for single quotes, as it's only available in the legacy FireboltOld dialect.

Suggested change ∙ Feature Preview

Move the Tokenizer class from FireboltOld to the main Firebolt dialect class:

class Firebolt(Dialect):
    class Tokenizer(tokens.Tokenizer):
        STRING_ESCAPES = ["'", "\\"]

    class Parser(parser.Parser):
        # ... rest of the code

💬 Chat with Korbit by mentioning @korbit-ai.