-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev/ci): pre-commit fixes galore #32352
Open
rusackas
wants to merge
14
commits into
master
Choose a base branch
from
pre-commit-touch-ups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,441
−2,142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbit doesn't automatically review large (3000+ lines changed) pull requests such as this one. If you want me to review anyway, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Related to the REST API
dependencies:npm
doc
Namespace | Anything related to documentation
github_actions
Pull requests that update GitHub Actions code
packages
preset-io
risk:db-migration
PRs that require a DB migration
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When running
pre-commit run --all-files
I was getting a TON of console noise, TS errors, lint errors, etc. This should tidy things up significantly, fixing all the errors, improving the eslint process for docs, and more.It also updates a couple of newer pre-commit hooks/linters to newer version, and makes changes accordingly.
One migration caught a hypothetical security issue, and that was addressed as well.
Frontend pre-commit jobs (prettier/eslint) now write fixes when run locally, so you can re-run and pass, but do not do this on CI, so they appropriately fail.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Let's see if CI passes!
ADDITIONAL INFORMATION