Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev/ci): pre-commit fixes galore #32352

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Feb 21, 2025

SUMMARY

When running pre-commit run --all-files I was getting a TON of console noise, TS errors, lint errors, etc. This should tidy things up significantly, fixing all the errors, improving the eslint process for docs, and more.

It also updates a couple of newer pre-commit hooks/linters to newer version, and makes changes accordingly.

One migration caught a hypothetical security issue, and that was addressed as well.

Frontend pre-commit jobs (prettier/eslint) now write fixes when run locally, so you can re-run and pass, but do not do this on CI, so they appropriately fail.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Let's see if CI passes!

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Feb 21, 2025

Korbit doesn't automatically review large (3000+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

@github-actions github-actions bot added doc Namespace | Anything related to documentation packages preset-io labels Feb 21, 2025
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Feb 22, 2025
@github-actions github-actions bot added risk:db-migration PRs that require a DB migration api Related to the REST API labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API dependencies:npm doc Namespace | Anything related to documentation github_actions Pull requests that update GitHub Actions code packages preset-io risk:db-migration PRs that require a DB migration size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant