THRIFT-5837 Delphi implementation for THRIFT-5835 #3068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial feature testcase added, compiler checks disabled. Patch: Jens Geyer
Client: Delphi Patch: Jens Geyer
|
The build seems to have been broken since this was merged. I can't seem to find the exact problem, but it seems it might be that some warnings are being treated as errors. This might not even be related to this change, but could be due to an update to the compiler in the GitHub Actions runner image. |
|
No idea how that slipped through - thanks, looking at it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: Delphi
Patch: Jens Geyer