Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings for Erlang/OTP 27 #3074

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

bjosv
Copy link
Contributor

@bjosv bjosv commented Dec 12, 2024

Client: Erlang
Since erlfmt is a build dependency, and the currently used version generates build warnings with latest OTP 27, we lift its version.

Example of warnings that are fixed:

===> Compiling erlfmt
    ┌─ _build/default/plugins/erlfmt/src/erlfmt_parse.yrl:
    │
 96 │  node -> standalone_exprs exprs dot : {exprs, (?range_anno('$1', '$3'))#{dot => true}, '$2'}.
    │                                                                        ╰── Warning: expression updates a literal

     ┌─ _build/default/plugins/erlfmt/src/erlfmt_parse.yrl:
     │
 149 │      {record, (?range_anno('$1', '$3'))#{macro_record => true}, '$1', []}.
     │                                        ╰── Warning: expression updates a literal
...

Includes a formatting correction (legacy) that is verified to work with the script build/veralign.sh.

This change is additionally tested to work with older OTP 23 and 24.

Client: Erlang

Since erlfmt is a build dependency, and the currently used version
generates new build warnings with latest OTP 27, we lift its version.
Includes a formatting correction that is verified to work with the
script build/veralign.sh

Signed-off-by: Björn Svensson <[email protected]>
@Jens-G Jens-G added the erlang label Dec 12, 2024
@Jens-G Jens-G merged commit 9171491 into apache:master Dec 12, 2024
18 of 22 checks passed
@bjosv bjosv deleted the erl-otp27-warnings branch December 13, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants