Fix documentation to match implementation #3076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean values are encoded as `BOOLEAN_TRUE` and `BOOLEAN_FALSE` which are defined as 1 and 2 instead of 1 and 0. The element-type of a bool is encoded as `BOOLEAN_TRUE` so 1 instead of 2.
Jens-G
reviewed
Dec 13, 2024
| @@ -249,7 +249,7 @@ The short form should be used when the length is in the range 0 - 14 (inclusive) | |||
|
|
|||
| The following element-types are used (see note below): | |||
|
|
|||
| * `BOOL`, encoded as `2` | |||
| * `BOOL`, encoded as `1` | |||
There was a problem hiding this comment.
That is debatable. A better word could be inconcistent.
- erlang and swift do it according to the spec and write 2
- anyone else writes 1
Hard to say who's wrong here
Jens-G
added a commit
that referenced
this pull request
Dec 13, 2024
Patch: Manuel Pöter & Jens Geyer This closes #3076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean values are encoded as
BOOLEAN_TRUEandBOOLEAN_FALSEwhich are defined as 1 and 2 instead of 1 and 0.The element-type of a bool is encoded as
BOOLEAN_TRUEso 1 instead of 2.[skip ci]