remove more Python2 compatibility #3079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://issues.apache.org/jira/browse/THRIFT-5537 is still open |
fishy
reviewed
Dec 26, 2024
| @@ -17,30 +17,13 @@ | |||
| # under the License. | |||
| # | |||
|
|
|||
| import sys | |||
| from io import BytesIO as BufferIO # noqa | |||
There was a problem hiding this comment.
why is this import needed? neither BytesIO nor BufferIO seems to be used in this file.
also, why the rename here?
There was a problem hiding this comment.
The two compat.py should go.
I planned to do this in the next PR
There was a problem hiding this comment.
ok looks like this is from old code
fishy
approved these changes
Dec 26, 2024
| @@ -17,30 +17,13 @@ | |||
| # under the License. | |||
| # | |||
|
|
|||
| import sys | |||
| from io import BytesIO as BufferIO # noqa | |||
There was a problem hiding this comment.
ok looks like this is from old code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a follow up to #3030
(which itself took over #2588)