Add log entry in WsAndHttpChannelizerHandler #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dh-cloud
force-pushed
the
fix-20241026-fixLogPrint
branch
from
f05644b
to
da03daa
Compare
|
Hi and thanks for contributing. You are currently targeting this PR to Also, do you mind putting a small entry into the CHANGELOG. |
dh-cloud
force-pushed
the
fix-20241026-fixLogPrint
branch
from
da03daa
to
a3980c8
Compare
dh-cloud
changed the title
kenhuuu
reviewed
Oct 29, 2024
| // For example, if the maxContentLength in JanusGraph's Gremlin-Server configuration is set to 65536, | ||
| // and the client sends data over this size via WebSocket, the JanusGraph server logs will appear normal, | ||
| // but the client will experience a disconnection, making it difficult to immediately identify the cause of the issue. | ||
| logger.error("Error processing request from netty", cause); |
There was a problem hiding this comment.
Suggested change
| logger.error("Error processing request from netty", cause); | |
| logger.error("Could not process the request", cause); |
Nit: the error should be slightly more generic to match what is done in gremlin-driver
|
Thanks, I just have one small nit regarding the logged message. VOTE +1, pending change. |
dh-cloud
force-pushed
the
fix-20241026-fixLogPrint
branch
from
a3980c8
to
f17d847
Compare
|
VOTE +1 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2855 +/- ##
=============================================
+ Coverage 76.14% 76.43% +0.28%
- Complexity 13152 13226 +74
=============================================
Files 1084 1060 -24
Lines 65160 61489 -3671
Branches 7285 7334 +49
=============================================
- Hits 49616 46999 -2617
+ Misses 12839 11975 -864
+ Partials 2705 2515 -190 ☔ View full report in Codecov by Sentry. |
The log entry here is necessary because when an exception thrown by Netty reaches exceptionCaught(), if the error is not printed, the server side will not be able to know what has happened. For example, if the maxContentLength in JanusGraph's Gremlin-Server configuration is set to 65536, and the client sends data over this size via WebSocket, the JanusGraph server logs will appear normal, but the client will experience a disconnection, making it difficult to immediately identify the cause of the issue.
dh-cloud
force-pushed
the
fix-20241026-fixLogPrint
branch
from
f17d847
to
8747760
Compare
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log entry here is necessary because when an exception thrown by
Netty reaches exceptionCaught(), if the error is not printed, the
server side will not be able to know what has happened.
For example, if the maxContentLength in JanusGraph's Gremlin-Server
configuration is set to 65536, and the client sends data over this
size via WebSocket, the JanusGraph server logs will appear normal,
but the client will experience a disconnection, making it difficult
to immediately identify the cause of the issue.