Transfer-Encoding:chunked log field fix #12667
Open
+41
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an origin server returns Transfer-Encoding:chunked, ATS removes
this header during response processing to handle dechunking. This
prevented the original header value from being logged via
%<{Transfer-Encoding}ssh>. This fix stores the original
Transfer-Encoding value before deletion and uses the stored value if
requested via the ssh field.
Fixes: apache#6261
bneradt
force-pushed
the
log_transfer_encoding_chunked
branch
from
f508f74 to
9e6a806
Compare
masaori335
reviewed
Nov 20, 2025
| bool trust_response_cl = false; | ||
| ResponseError_t response_error = ResponseError_t::NO_RESPONSE_HEADER_ERROR; | ||
| bool extension_method = false; | ||
| std::string server_response_transfer_encoding; ///< Storage for logging. |
Contributor
There was a problem hiding this comment.
IIUC, current.server->transfer_encoding stores the type of Transfer-Encoding. De we really need copy of the header here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an origin server returns Transfer-Encoding:chunked, ATS removes
this header during response processing to handle dechunking. This
prevented the original header value from being logged via
%<{Transfer-Encoding}ssh>. This fix stores the original
Transfer-Encoding value before deletion and uses the stored value if
requested via the ssh field.
Fixes: #6261