Fix format specifier for ip_source bitfield in header_rewrite #12677
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[approve ci] |
bryancall
force-pushed
the
fix-ubuntu-build
branch
3 times, most recently
from
c11bd76 to
4bd8093
Compare
Use PRIu64 with explicit cast to uint64_t to match the bitfield's underlying type and ensure cross-platform compatibility. This fixes build failures on Ubuntu 20.04.
bryancall
force-pushed
the
fix-ubuntu-build
branch
from
4bd8093 to
993e58b
Compare
Member
|
It looks like either the description is outdated or you forgot to git add the other change (tcpinfo). |
Contributor
Author
|
@maskit I removed the tcpinfo change in this commit, I am fixing only one issue at a time and will see what CI does next. I updated the description of the PR. |
maskit
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix build failures on Ubuntu 20.04 in header_rewrite.
Changes
Testing