Skip to content

Conversation

@junrushao
Copy link
Member

@junrushao junrushao commented Sep 17, 2025

This PR makes the following changes:

  • Introduces pre-commit hooks that includes:
    • check-yaml
    • check-toml
    • ruff-check and ruff-format
    • clang-format
    • cython-lint
    • shell-format
    • shell-check
    • ASF header checks (migrated from task_lint.sh)
    • Filetype checks (migrated from task_lint.sh)
  • Removes tests/scripts/task_lint.sh and unnecessary/conflicting checks, including:
    • isort (part of ruff-format)
    • black (part of ruff-format)
  • Updates lint stage in ci_test.yml, replacing task_lint.sh with native pre-commit hooks
  • Makes stage test to additionally depend on lint

@junrushao junrushao marked this pull request as ready for review September 17, 2025 18:27
@junrushao junrushao requested a review from tqchen September 17, 2025 18:27
@junrushao junrushao force-pushed the 2025-09-17/pre-commit-hooks branch from f624b56 to 88205af Compare September 17, 2025 20:44
@tqchen
Copy link
Member

tqchen commented Sep 17, 2025

maybe worthwhile push to a branch since action won't run for updated yaml

@junrushao junrushao force-pushed the 2025-09-17/pre-commit-hooks branch from 88205af to 540d289 Compare September 17, 2025 21:01
@junrushao
Copy link
Member Author

@tqchen it should work now

@tqchen tqchen merged commit 64e4b7f into apache:main Sep 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants