-
Notifications
You must be signed in to change notification settings - Fork 48
doc: Final tweaks on Python Packaging #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @junrushao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation related to Python packaging and ABI concepts. It enhances the clarity of the ABI overview by updating its title and provides crucial guidance on how to access global functions across different languages within the TVM FFI framework. Additionally, a small organizational tweak was made to an example C++ file to improve code readability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides some final tweaks to the Python packaging documentation. The changes are mostly good, clarifying how to retrieve global functions and adjusting the title of the ABI overview. However, there are a couple of minor issues. One is a small correction in a reStructuredText cross-reference. The other is a change to an example file that makes the documentation inconsistent. My review includes suggestions to address these points.
| static int AddOne(int x) { return x + 1; } | ||
| // [global_function.end] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By moving // [global_function.end] here, the code snippet included in the documentation no longer shows the registration of the AddOne function using tvm::ffi::reflection::GlobalDef. This makes the accompanying text in docs/packaging/python_packaging.rst confusing, as it specifically describes this registration process. For consistency with other examples in the document (like the Class example which shows both definition and registration), it would be better to include the registration block. Please consider reverting this change and the corresponding removal of the tag at the end of the TVM_FFI_STATIC_INIT_BLOCK.
cbe27d6 to
4bc0a2a
Compare
No description provided.