feat(typing): Parameterizable Array[T] and Map[K, V]
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `Array` and `Map` types, despite that they inherit from `collections.abc.Sequence` and `Mapping`, are not properly parameterized. This PR makes it work.
junrushao
force-pushed
the
2025-09-21/ty-list-map
branch
from
09f7273 to
6c67ed7
Compare
tqchen
approved these changes
Sep 22, 2025
tqchen
pushed a commit
that referenced
this pull request
Sep 23, 2025
This PR fixes a behavioral inconsistency between existing TVM stack and the latest `main`. Originally, slicing a `tvm_ffi.Array[T]` always returns `list[T]`. This behavior was altered by PR #37, which instead returns `Array[T]`, breaking a few unittests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #35.
Previously
ArrayandMaptypes, despite that they inherit fromcollections.abc.SequenceandMapping, are not properly parameterized. This PR makes it work.