Skip to content

Conversation

@cyx-6
Copy link
Contributor

@cyx-6 cyx-6 commented Jan 6, 2026

This PR adds the license and notice for torch-c-dlpack-ext to align with tvm ffi

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cyx-6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the licensing for the torch-c-dlpack-ext addon by integrating the Apache License 2.0 and a corresponding NOTICE file. These changes ensure legal compliance and align the project's licensing with the TVM FFI, while also updating the build configuration to properly package these new legal documents.

Highlights

  • License Addition: The full text of the Apache License, Version 2.0, has been added for the torch-c-dlpack-ext component.
  • Notice File Introduction: A new NOTICE file has been created for torch-c-dlpack-ext, attributing copyright to The Apache Software Foundation.
  • Project Metadata Update: The pyproject.toml file has been updated to declare the Apache 2.0 license, specify authors, add classifiers, and ensure the new license and notice files are included in the package distribution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the LICENSE and NOTICE files for the torch-c-dlpack-ext addon and updates pyproject.toml to include them in the package. The changes are good for license compliance. I have a few suggestions to improve the packaging configuration in pyproject.toml to follow setuptools best practices and a correction for the LICENSE file content to keep it clean.

@tqchen tqchen merged commit 5bf7e8c into apache:main Jan 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants