chore: replace C-style cast with static_cast in String::substr

[guan404ming]

Related

https://github.com/apache/tvm-ffi/actions/runs/20755375337/job/59595882892

Why

clang-tidy fails with google-readability-casting error due to C-style cast in default parameter.

How

Replace size_t(-1) with nops in String::substr method

[gemini-code-assist]

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code readability and adhering to modern C++ casting conventions by replacing a C-style cast with static_cast. The change specifically targets the default parameter of the String::substr method, resolving a clang-tidy warning related to casting practices. The primary impact is enhanced code quality and consistency with established coding standards, ensuring cleaner and more maintainable code.

Highlights

• Casting Style Update: Replaced a C-style cast (size_t(-1)) with a static_cast (static_cast<size_t>(-1)) within the default parameter of the String::substr method.
• Clang-Tidy Compliance: Addressed a google-readability-casting error reported by clang-tidy, improving code quality and adherence to modern C++ casting conventions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly replaces a C-style cast with static_cast to resolve a clang-tidy warning. This is a good improvement for code quality and clarity. I've added one suggestion to further improve consistency by using the class's npos member for the default argument, which aligns with the convention used in std::string and other methods within this class.

[junrushao]

LGTM

[guan404ming]

Thanks!