Skip to content

Conversation

@cyx-6
Copy link
Contributor

@cyx-6 cyx-6 commented Oct 8, 2025

This PR exposes the get env stream method as followup of #5.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cyx-6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request exposes a new get_raw_stream method within the tvm_ffi.stream module, allowing users to retrieve the current FFI stream associated with a given device. This is achieved by adding a Cython binding (_env_get_stream) to an internal C++ function, defining the public Python API, and updating the module's __init__.py. New test assertions confirm the method's correct behavior, particularly within use_raw_stream contexts.

Highlights

  • Intent: This pull request aims to expose a method to retrieve the current FFI stream for a given device, following up on a previous issue (Add stream context #5).
  • Changes Overview: The PR introduces a new public function get_raw_stream in the tvm_ffi.stream module. This function allows users to query the currently active stream for a specified device. The implementation involves adding a Cython binding to an internal C++ function (TVMFFIEnvGetStream) and updating the __init__.py to expose the new method. Corresponding tests have been added to verify its functionality within stream contexts.
  • File Changes: The changes are distributed across four files:
  • python/tvm_ffi/__init__.py: Updated to import the newly exposed get_raw_stream function.
  • python/tvm_ffi/cython/base.pxi: A new Cython function _env_get_stream was added to provide a Python-callable wrapper for the internal TVMFFIEnvGetStream C++ function, enabling retrieval of the raw stream pointer.
  • python/tvm_ffi/stream.py: The public get_raw_stream function was defined, which takes a tvm_ffi.Device object and uses the new Cython binding to return the current stream as an integer. A comprehensive docstring was also added.
  • tests/python/test_stream.py: The test_raw_stream function was enhanced with assertions to confirm that get_raw_stream correctly reports the active stream when use_raw_stream context managers are used, including nested contexts.
  • Reviewer Activity: No specific reviewer activity or comments were provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a great pull request that is well-structured and includes the necessary tests. I've found one issue that should be addressed.

@tqchen tqchen merged commit 22c049b into apache:main Oct 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants