XGC-148: drop commons-io dependency #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/org/apache/xmlgraphics/util/uri/DataURIResolverTestCase.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/xmlgraphics/image/loader/impl/AbstractImageSessionContext.java
Outdated
Show resolved
Hide resolved
vlsi
force-pushed
the
commonsio
branch
3 times, most recently
from
2f13415 to
1d7064b
Compare
vlsi
changed the title
Author
|
I see the CI checks fail, and I suggest a fix for it: #33 |
Author
|
@simonsteiner1984 , any thoughts? |
Author
|
Is there a reason of not merging the PR? Frankly, it looks sad to miss myself here: https://github.com/apache/xmlgraphics-commons/graphs/contributors |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.apache.org/jira/browse/XGC-148
TODO:
IOUtils.closeQuitely— replaced withtry-with-resourcesIOUtils.toString(Reader)— implemented a function in test (it was used in a single test only)IOUtils.copy. Java 9 hasInputStream.transferTo(OutputStream)IOUtils.toByteArray. Java 9 hasInputStream.readAllBytes()commons.io.output.ByteArrayOutputStream. I see that there were no consistent use ofcommons.ByteArrayOutputStream, so I replaced all the usages withjava.io.ByteArrayOutputStreamEndianUtils.readSwappedInteger