Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PROJECT_SOURCE_DIR instead of CMAKE_CURRENT_SOURCE_DIR where appropriate #154

Conversation

apcountryman
Copy link
Owner

Resolves #153 (Use PROJECT_SOURCE_DIR instead of
CMAKE_CURRENT_SOURCE_DIR where appropriate).

This pull request:

  • Implements a bug fix
  • Implements an enhancement to an existing feature
  • Implements a new feature
  • Performs a refactoring
  • Performs a repository administrative action

Please mark the pull request as "Ready for review" and request a review when the pull
request is ready for a review.
If changes are requested, please discuss and/or address the review findings before
requesting a new review.

…opriate

Resolves #153 (Use PROJECT_SOURCE_DIR instead of
CMAKE_CURRENT_SOURCE_DIR where appropriate).
@apcountryman apcountryman added priority-normal Work that will be released status-in_review In review type-refactoring Refactoring labels Apr 4, 2024
@apcountryman apcountryman self-assigned this Apr 4, 2024
Copy link
Owner Author

@apcountryman apcountryman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No review findings.

@apcountryman apcountryman merged commit b38668e into main Apr 4, 2024
2 checks passed
@apcountryman apcountryman deleted the 153-use_project_source_dir_instead_of_cmake_current_source_dir_where_appropriate branch April 4, 2024 20:22
@apcountryman apcountryman added status-complete Work complete and removed status-in_review In review labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-normal Work that will be released status-complete Work complete type-refactoring Refactoring
Projects
Development

Successfully merging this pull request may close these issues.

Use PROJECT_SOURCE_DIR instead of CMAKE_CURRENT_SOURCE_DIR where appropriate
1 participant