-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pg): COPY TO STDOUT #184
Conversation
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 suggestion.
Files not reviewed (2)
- pgserver/connection_data.go: Evaluated as low risk
- pgserver/connection_handler.go: Evaluated as low risk
Comments skipped due to low confidence (2)
pgserver/datawriter.go:25
- Ensure that the
query
parameter is not empty whentable
isnil
to prevent potential issues.
query string,
pgserver/validate.go:33
- [nitpick] The variable name 'it' is ambiguous. It should be renamed to 'insertableTable'.
if it, ok := table.(sql.InsertableTable); !ok {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! And now we can dump the data from MyDuck by PostgreSQL clients.
No description provided.