Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pg): COPY TO STDOUT #184

Merged
merged 11 commits into from
Nov 21, 2024
Merged

feat(pg): COPY TO STDOUT #184

merged 11 commits into from
Nov 21, 2024

Conversation

fanyang01
Copy link
Collaborator

No description provided.

@fanyang01 fanyang01 requested a review from Copilot November 20, 2024 14:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 suggestion.

Files not reviewed (2)
  • pgserver/connection_data.go: Evaluated as low risk
  • pgserver/connection_handler.go: Evaluated as low risk
Comments skipped due to low confidence (2)

pgserver/datawriter.go:25

  • Ensure that the query parameter is not empty when table is nil to prevent potential issues.
query string,

pgserver/validate.go:33

  • [nitpick] The variable name 'it' is ambiguous. It should be renamed to 'insertableTable'.
if it, ok := table.(sql.InsertableTable); !ok {

backend/pipe.go Outdated Show resolved Hide resolved
@fanyang01 fanyang01 requested a review from VWagen1989 November 21, 2024 07:52
Copy link
Contributor

@VWagen1989 VWagen1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And now we can dump the data from MyDuck by PostgreSQL clients.

@fanyang01 fanyang01 merged commit 8d7dab9 into main Nov 21, 2024
5 checks passed
@fanyang01 fanyang01 mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants