Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: arrow in, arrow out #205

Merged
merged 2 commits into from
Nov 22, 2024
Merged

feat: arrow in, arrow out #205

merged 2 commits into from
Nov 22, 2024

Conversation

fanyang01
Copy link
Collaborator

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated no suggestions.

Files not reviewed (5)
  • pgtest/psql/copy/arrow.sql: Language not supported
  • pgserver/arrowloader.go: Evaluated as low risk
  • pgserver/connection_handler.go: Evaluated as low risk
  • pgserver/copy_test.go: Evaluated as low risk
  • pgserver/dataloader.go: Evaluated as low risk
Comments skipped due to low confidence (2)

pgserver/copy.go:1

  • [nitpick] The function name ParseCopyOptions could be more descriptive, such as ParseCopyFormatOptions, to indicate that it parses format-specific options.
package pgserver

pgserver/copy.go:78

  • [nitpick] The type name OptionValueType could be more descriptive, such as CopyOptionValueType, to indicate that it is related to COPY options.
type OptionValueType uint8
Copy link
Contributor

@VWagen1989 VWagen1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's really an amazing feature! With this MyDuck and propagate data outside and load data inside in pure columnar format! Congrats, Great job!

@fanyang01 fanyang01 merged commit 2943d53 into main Nov 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants