Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pre-install the required DuckDB extensions #217

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

fanyang01
Copy link
Collaborator

@fanyang01 fanyang01 commented Nov 26, 2024

Resolves #149

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • docker/Dockerfile: Language not supported
Comments skipped due to low confidence (2)

main.go:45

  • [nitpick] The variable name initMode is ambiguous. It should be renamed to initializeMode.
initMode = false

main.go:102

  • The new behavior introduced by initMode is not covered by tests. Please add tests to ensure this behavior is correctly handled.
if initMode {
@fanyang01 fanyang01 merged commit 95fcd84 into main Nov 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to download extension "arrow" when starting server
1 participant