Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compatibility tests for clients #218

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Update compatibility tests for clients #218

merged 2 commits into from
Nov 28, 2024

Conversation

NoyException
Copy link
Contributor

No description provided.

@NoyException NoyException marked this pull request as ready for review November 26, 2024 11:29
@NoyException NoyException enabled auto-merge (squash) November 26, 2024 11:30
@TianyuZhang1214
Copy link
Contributor

It seems all tests for MySQL failed?

@NoyException
Copy link
Contributor Author

It seems all tests for MySQL failed?

Yes. They almost all come from the same bug, which happens during the query. (which means the bug is not produced by the test script)

 SQLSTATE[HY000]: General error: 1105 error: 'types.OkResult' is not a valid value type for 'int'

@fanyang01
Copy link
Collaborator

Great work! So many programming languages :-)

I guess these failures could be resolved by a simple fix. Could you please look into it?

@NoyException
Copy link
Contributor Author

Great work! So many programming languages :-)

I guess these failures could be resolved by a simple fix. Could you please look into it?

Sure. I will try it.

TianyuZhang1214
TianyuZhang1214 requested changes Nov 27, 2024
View reviewed changes
compatibility/mysql/c/mysql_test.c Show resolved Hide resolved
compatibility/mysql/csharp/MySQLTest.cs Outdated Show resolved Hide resolved
compatibility/mysql/csharp/MySQLTest.cs Outdated Show resolved Hide resolved
compatibility/mysql/csharp/MySQLTest.cs Show resolved Hide resolved
@fanyang01
Copy link
Collaborator

Why does the Postgres compatiability test fail for more languages? Previously, it only failed for Java.

@NoyException
Copy link
Contributor Author

NoyException commented Nov 27, 2024 •
edited
Loading

Why does the Postgres compatiability test fail for more languages? Previously, it only failed for Java.

It failed for Java and PHP previously. In this update, I add 5 more languages, in which many of them failed.

Python is an exception. I fixed the bug in mysql-python, then I synced up the modification to pg-python, which caused an unexpected failure.

TianyuZhang1214
TianyuZhang1214 requested changes Nov 27, 2024
View reviewed changes
compatibility/mysql/go/mysql.go Outdated Show resolved Hide resolved
compatibility/mysql/go/mysql.go Show resolved Hide resolved
compatibility/mysql/go/mysql.go Outdated Show resolved Hide resolved
@fanyang01
Copy link
Collaborator

fanyang01 commented Nov 27, 2024 •
edited
Loading

Let's comment out failed languages to make the CI healthy and fix the failures one-by-one in the next step.

@NoyException NoyException enabled auto-merge (squash) November 28, 2024 09:53
@fanyang01 fanyang01 disabled auto-merge November 28, 2024 10:11
@fanyang01 fanyang01 merged commit 42200b9 into apecloud:main Nov 28, 2024
7 checks passed
@fanyang01 fanyang01 mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TianyuZhang1214 TianyuZhang1214 TianyuZhang1214 requested changes

@fanyang01 fanyang01 fanyang01 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoyException @TianyuZhang1214 @fanyang01