Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'types.OkResult' is not a valid value type for 'int' #222

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

fanyang01
Copy link
Collaborator

This PR resolves the following error:

mysql> UPDATE tb1 SET value=3.3 WHERE id=1;
ERROR 1105 (HY000): error: 'types.OkResult' is not a valid value type for 'int'

The root cause is that we return types.OkResultSchema for DMLs, which breaks go-mysql-server's assumptions. I have modified our fork of go-mysql-server to be more robust.

Copy link
Contributor

@NoyException NoyException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@fanyang01 fanyang01 merged commit be94e37 into main Nov 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants