Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add compatibility test for python data tools, fix some compatibility bugs (#209) #248

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: add compatibility test for python data tools, fix some compatibility bugs (#209) #248

merged 1 commit into from
Dec 3, 2024

Conversation

NoyException
Copy link
Contributor

No description provided.

@NoyException NoyException marked this pull request as ready for review December 3, 2024 09:37
fanyang01
fanyang01 reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@fanyang01 fanyang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. These are an excellent set of comprehensive test cases!

compatibility/pg-pytools/polars_test.py Outdated Show resolved Hide resolved
docs/tutorial/pg-python-data-tools.md Outdated Show resolved Hide resolved
pgserver/connection_handler.go Outdated Show resolved Hide resolved
docs/tutorial/pg-python-data-tools.md Outdated Show resolved Hide resolved
docs/tutorial/pg-python-data-tools.md Outdated Show resolved Hide resolved
docs/tutorial/pg-python-data-tools.md Outdated Show resolved Hide resolved
docs/tutorial/pg-python-data-tools.md Outdated Show resolved Hide resolved
@NoyException NoyException enabled auto-merge (squash) December 3, 2024 12:05
fanyang01
fanyang01 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@fanyang01 fanyang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@fanyang01 fanyang01 disabled auto-merge December 3, 2024 12:53
@fanyang01 fanyang01 merged commit 533e246 into apecloud:main Dec 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TianyuZhang1214 TianyuZhang1214 TianyuZhang1214 requested changes

@fanyang01 fanyang01 fanyang01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoyException @fanyang01 @TianyuZhang1214