perf: skip index creation for replicated table

[fanyang01]

Ref: #272

Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 suggestion.

Files not reviewed (4)

• catalog/database.go: Evaluated as low risk
• replica/replication.go: Evaluated as low risk
• catalog/table.go: Evaluated as low risk
• pgserver/logrepl/ddl.go: Evaluated as low risk

Comments skipped due to low confidence (3)

configuration/env.go:9

• The constant name replicationWithoutIndex should be in uppercase to follow Go naming conventions. Rename it to REPLICATION_WITHOUT_INDEX.

replicationWithoutIndex = "REPLICATION_WITHOUT_INDEX"

pgserver/logrepl/replication_test.go:748

• The comment should explicitly mention why the primary key index is being removed from the replica table when the environment variable is set.

if target == "replica" && configuration.IsReplicationWithoutIndex() {

pgserver/logrepl/replication_test.go:747

• Ensure that test cases cover both scenarios: when the environment variable is set and when it is not set.

target, _ := clientSpecFromQueryComment(query)

[VWagen1989]

Great job! LGTM! I'll test the replication performance after this PR is merged.