Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add MariaDB & Dolt as replication sources #303

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

fanyang01
Copy link
Collaborator

@fanyang01 fanyang01 commented Dec 19, 2024

Resolves #153

Unfortunately, both MariaDB and Dolt are not supported by the REPLICA mode.

@fanyang01 fanyang01 requested a review from Copilot December 19, 2024 10:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/replication-test.yml:46

  • The directory path for the dolt configuration file might cause issues if the directory doesn't exist. Ensure the directory is created before writing the file.
cat <<EOF > doltcfg/config.json

.github/workflows/replication-test.yml:127

  • [nitpick] The variable SCHEMA is being set multiple times with the same value in different conditions. This could be simplified to avoid redundancy.
SCHEMA=test
@fanyang01 fanyang01 merged commit 78284ce into main Dec 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests for replication
1 participant